Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: update dependency eslint-plugin-react-refresh to v0.4.14 #1289

Open
wants to merge 2 commits into from
Open

deps: update dependency eslint-plugin-react-refresh to v0.4.14 #1289

wants to merge 2 commits into from
+46 −21

Conversation

eclipse-apoapsis-bot
Copy link
Contributor

@eclipse-apoapsis-bot eclipse-apoapsis-bot commented Oct 24, 2024 •
edited
Loading

This PR contains the following updates:

Package Type Update Change
eslint-plugin-react-refresh devDependencies patch 0.4.13 -> 0.4.14

Release Notes

ArnaudBarre/eslint-plugin-react-refresh (eslint-plugin-react-refresh)

v0.4.14

Compare Source

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

@eclipse-apoapsis-bot eclipse-apoapsis-bot added the dependencies Dependency update label Oct 24, 2024
nnobelis
nnobelis previously approved these changes Oct 25, 2024
View reviewed changes
@nnobelis
Copy link
Contributor

@Etsija Could you please check why the CI test fails ?

@Etsija
Copy link
Contributor

Etsija commented Oct 25, 2024

@Etsija Could you please check why the CI test fails ?

I know why, but I don't know how it's failing only just now, because that should've failed for a long time already. Maybe there's been a recent component update which breaks it. I'll investigate.

@Etsija
Copy link
Contributor

Etsija commented Oct 25, 2024

Oh, found the reason. It's because in earlier versions, context export alongside the component export was not checked for, and now it is. Well that explains it. I'll see how to fix it.

@Etsija Etsija force-pushed the renovate-action/eslint-plugin-react-refresh-0.x-lockfile branch from 974950a to 1b9e1fb Compare October 25, 2024 07:33
@Etsija
Copy link
Contributor

Etsija commented Oct 25, 2024 •
edited
Loading

@mmurto I managed to fix the problem with my commit, could you have a look at it? I tested the UI and theme switching seems to work.

@Etsija Etsija requested a review from nnobelis October 25, 2024 07:38
mmurto
mmurto requested changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@mmurto mmurto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just reorder the commits to first fix it and then update eslint and we're good to go.

@Etsija Etsija force-pushed the renovate-action/eslint-plugin-react-refresh-0.x-lockfile branch from 1b9e1fb to cfc1122 Compare October 25, 2024 10:24
@Etsija Etsija force-pushed the renovate-action/eslint-plugin-react-refresh-0.x-lockfile branch 2 times, most recently from 0fecd31 to cfc1122 Compare October 25, 2024 10:30
@Etsija
Copy link
Contributor

Etsija commented Oct 25, 2024 •
edited
Loading

I don't know what is happening, but even with native Git, the commits seem to be exactly in right order (mine first, then the plugin update). I don't know how to solve GitHub showing them in wrong order.
Screenshot from 2024-10-25 13-47-09

@eclipse-apoapsis-bot eclipse-apoapsis-bot force-pushed the renovate-action/eslint-plugin-react-refresh-0.x-lockfile branch from cfc1122 to bb33609 Compare October 25, 2024 10:47
@mmurto
Copy link
Contributor

mmurto commented Oct 25, 2024

I don't know what is happening, but even with native Git, the commits seem to be exactly in right order (mine first, then the plugin update). I don't know how to solve GitHub showing them in wrong order. Screenshot from 2024-10-25 13-47-09

git log shows the newest commit on top. I'd do an interactive rebase and reorder them.

@Etsija
Copy link
Contributor

Etsija commented Oct 25, 2024 •
edited
Loading

git log shows the newest commit on top. I'd do an interactive rebase and reorder them.

And the newest commit is the eslint update, as it should? Anyway, I removed my commit from the PR, now trying to do it again manually.

@mmurto
Copy link
Contributor

mmurto commented Oct 25, 2024

git log shows the newest commit on top. I'd do an interactive rebase and reorder them.

And the newest commit is the eslint update, as it should? Anyway, I removed my commit from the PR, now trying to do it again manually.

Ah true, sorry. I guess GitButler didn't change the dates, as you see that git log shows your commit to be on 25th and the update to be on 24th. Rebase should take care of that.

Etsija and others added 2 commits October 25, 2024 14:02
@Etsija
refactor(ui): Fix illegal exports
236453f 
Exporting context alongside a component in code files breaks the hot
reload functionality of `eslint-plugin-react-refresh`, so in release
v0.4.14 this produces a warning [1], and since no warnings are allowed,
the eslint check fails.

Add a `ThemeProviderState` which works as a middleman between
`ThemeProvider` and `ThemeProviderContext`, to ensure there are no illegal
exports from any files.

[1]: https://tinyurl.com/4whfwy5x

Signed-off-by: Jyrki Keisala <[email protected]>
@eclipse-apoapsis-bot @Etsija
deps: update dependency eslint-plugin-react-refresh to v0.4.14
f8f147b
@Etsija Etsija force-pushed the renovate-action/eslint-plugin-react-refresh-0.x-lockfile branch from bb33609 to f8f147b Compare October 25, 2024 11:03
@Etsija
Copy link
Contributor

Etsija commented Oct 25, 2024

Ah true, sorry. I guess GitButler didn't change the dates, as you see that git log shows your commit to be on 25th and the update to be on 24th. Rebase should take care of that.

Should be in order now.

@mmurto mmurto enabled auto-merge October 25, 2024 11:07
@eclipse-apoapsis-bot
Copy link
Contributor Author

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

@mmurto mmurto added this pull request to the merge queue Oct 25, 2024
Any commits made after this event will not be merged.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmurto mmurto mmurto approved these changes

@Etsija Etsija Awaiting requested review from Etsija Etsija is a code owner

@nnobelis nnobelis Awaiting requested review from nnobelis

Assignees
No one assigned
Labels
dependencies Dependency update
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eclipse-apoapsis-bot @nnobelis @Etsija @mmurto