-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: update dependency eslint-plugin-react-refresh to v0.4.14 #1289
deps: update dependency eslint-plugin-react-refresh to v0.4.14 #1289
Conversation
@Etsija Could you please check why the CI test fails ? |
I know why, but I don't know how it's failing only just now, because that should've failed for a long time already. Maybe there's been a recent component update which breaks it. I'll investigate. |
Oh, found the reason. It's because in earlier versions, context export alongside the component export was not checked for, and now it is. Well that explains it. I'll see how to fix it. |
974950a
to
1b9e1fb
Compare
@mmurto I managed to fix the problem with my commit, could you have a look at it? I tested the UI and theme switching seems to work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just reorder the commits to first fix it and then update eslint and we're good to go.
1b9e1fb
to
cfc1122
Compare
0fecd31
to
cfc1122
Compare
cfc1122
to
bb33609
Compare
And the newest commit is the eslint update, as it should? Anyway, I removed my commit from the PR, now trying to do it again manually. |
Ah true, sorry. I guess GitButler didn't change the dates, as you see that git log shows your commit to be on 25th and the update to be on 24th. Rebase should take care of that. |
Exporting context alongside a component in code files breaks the hot reload functionality of `eslint-plugin-react-refresh`, so in release v0.4.14 this produces a warning [1], and since no warnings are allowed, the eslint check fails. Add a `ThemeProviderState` which works as a middleman between `ThemeProvider` and `ThemeProviderContext`, to ensure there are no illegal exports from any files. [1]: https://tinyurl.com/4whfwy5x Signed-off-by: Jyrki Keisala <[email protected]>
bb33609
to
f8f147b
Compare
Should be in order now. |
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
This PR contains the following updates:
0.4.13
->0.4.14
Release Notes
ArnaudBarre/eslint-plugin-react-refresh (eslint-plugin-react-refresh)
v0.4.14
Compare Source
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Renovate Bot.